Skip to content

Feat/region adjustment rabbitmq#1449

Merged
marceljk merged 7 commits into
mainfrom
feat/region-adjustment-rabbitmq
Jul 6, 2026
Merged

Feat/region adjustment rabbitmq#1449
marceljk merged 7 commits into
mainfrom
feat/region-adjustment-rabbitmq

Conversation

@SerseusWasTaken

@SerseusWasTaken SerseusWasTaken commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Migrates to rabbitmq api v2 and implements appropriate region adjustments

relates to STACKITCLI-407 and STACKITCLI-375

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@SerseusWasTaken SerseusWasTaken force-pushed the feat/region-adjustment-rabbitmq branch 4 times, most recently from 5470441 to 10231b7 Compare June 30, 2026 06:17
@SerseusWasTaken SerseusWasTaken marked this pull request as ready for review June 30, 2026 06:22
@SerseusWasTaken SerseusWasTaken requested a review from a team as a code owner June 30, 2026 06:22
marceljk
marceljk reviewed Jun 30, 2026
View reviewed changes
Comment thread internal/cmd/rabbitmq/instance/create/create.go Outdated
marceljk
marceljk reviewed Jun 30, 2026
View reviewed changes
Comment thread internal/cmd/rabbitmq/instance/create/create.go Outdated
marceljk
marceljk reviewed Jun 30, 2026
View reviewed changes
Comment thread internal/cmd/rabbitmq/instance/create/create.go Outdated
marceljk
marceljk reviewed Jun 30, 2026
View reviewed changes
Comment thread internal/cmd/rabbitmq/instance/create/create_test.go Outdated
marceljk
marceljk reviewed Jun 30, 2026
View reviewed changes
Comment thread internal/cmd/rabbitmq/instance/update/update.go Outdated
marceljk
marceljk reviewed Jun 30, 2026
View reviewed changes
Comment thread internal/pkg/flags/flag_to_value.go Outdated
GokceGK
GokceGK reviewed Jun 30, 2026
View reviewed changes
Comment thread internal/pkg/services/rabbitmq/utils/utils.go Outdated
@SerseusWasTaken SerseusWasTaken force-pushed the feat/region-adjustment-rabbitmq branch from b255714 to 8d63286 Compare July 2, 2026 12:21
@SerseusWasTaken SerseusWasTaken force-pushed the feat/region-adjustment-rabbitmq branch from 8d63286 to aadb2a0 Compare July 2, 2026 12:23
marceljk
marceljk previously approved these changes Jul 6, 2026
View reviewed changes
Comment thread internal/cmd/rabbitmq/instance/create/create.go Outdated
Comment thread internal/cmd/rabbitmq/instance/update/update.go Outdated
Comment thread internal/cmd/rabbitmq/instance/update/update_test.go
@marceljk marceljk enabled auto-merge (squash) July 6, 2026 14:59
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/create 60.00% (+2.11%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/delete 37.50% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/describe 56.82% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/list 60.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/create 61.86% (+0.40%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/delete 26.83% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/describe 65.96% (+7.62%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/list 60.00% (+2.31%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/update 58.95% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/plans 53.85% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/utils 26.67% (+1.67%) 👍
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/create/create.go 60.00% (+2.11%) 55 (-2) 33 22 (-2) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/delete/delete.go 37.50% (ø) 40 15 25
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/describe/describe.go 56.82% (ø) 44 25 19
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/list/list.go 60.00% (ø) 50 30 20
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/create/create.go 61.86% (+0.40%) 97 (+1) 60 (+1) 37 👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/delete/delete.go 26.83% (ø) 41 11 30
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/describe/describe.go 65.96% (+7.62%) 47 (-1) 31 (+3) 16 (-4) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/list/list.go 60.00% (+2.31%) 50 (-2) 30 20 (-2) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/update/update.go 58.95% (ø) 95 56 39
github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/plans/plans.go 53.85% (ø) 52 28 24
github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/client/client.go 0.00% (ø) 1 0 1
github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/utils/utils.go 26.67% (+1.67%) 30 (-2) 8 22 (-2) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/credentials/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/instance/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/rabbitmq/plans/plans_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/rabbitmq/utils/utils_test.go

@marceljk marceljk merged commit 3f95acd into main Jul 6, 2026
3 checks passed
@marceljk marceljk deleted the feat/region-adjustment-rabbitmq branch July 6, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marceljk marceljk marceljk approved these changes
@GokceGK GokceGK GokceGK approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SerseusWasTaken @marceljk @GokceGK